Ticket #126 (closed defect: invalid)

Opened 5 months ago

Last modified 5 months ago

if cache is missing, imdbphp shouldn't display it

Reported by: jcv Owned by: izzy
Priority: critical Milestone: 2.0
Component: other Keywords: cache 1.9.9
Cc: Blocking:
Blocked By:

Description

Has to be related to the new cache management system, but… just updated to release 1.9.9, and had the surprise to get read comments if cache has not yet been generated.

For exemple, when looking for 2001 movie :

cache_read: requested file '2001.search' not found in cache dir '/home/www/5f78fec20ccd97d73a648cfeb63c2202/[cache adress…]' imdbsearch::results() called. Using URL  http://akas.imdb.com/find?q=2001;mx=20;tt=on cache_read: requested file '0062622.Title' not found in cache dir '/home/www/5f78fec20ccd97d73a648cfeb63c2202/[cache adress…]'

is displayed before showing the very movie's details… Same about credits (cache_read: requested file ‘0212671.Credits’ [and so on]) or every single cache file produced by imdbphp.

Attachments

Change History

Changed 5 months ago by izzy

  • status changed from new to pending

You are right, it should not - but you might have turned debug mode on, and then it should. Here's the corresponding code line:

    if (!file_exists($fname)) {
      $this->debug_scalar("cache_read: requested file '$file' not found in cache dir '".$this->cachedir."'");

I guess the unexpected output was displayed in red? This would be a clear sign debug is turned on. Could you please check this? I found no other sign of evidence in the code it could be caused from.

Changed 5 months ago by jcv

  • status changed from pending to assigned

Well, you're absolutely right. I double checked, but say, it wasn't enough :/

Sorry for reporting this false alert. Debug was on, and I'm off :)

Changed 5 months ago by izzy

  • status changed from assigned to closed
  • resolution set to invalid

No problem - I love those self-solving problems more than those IMDB site changes ;)

Btw: I recommend you to create an account here, as you are one of the most active users. If you do so, you'll be able to close your tickets yourself - amongst other things…

Add/Change #126 (if cache is missing, imdbphp shouldn't display it)

Short guidelines for modifying a ticket:

  • Don't change these ticket fields: assign to, priority, milestone, keywords
  • Don't change a ticket field without leaving a comment.
  • Don't close or reopen a ticket without a reason.

For more information see the full version of the ticket guidelines.

Author


E-mail address and user name can be saved in the Preferences.


Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.